Re-work colcon_core.command.get_prog_name #617
Conversation
This function's purpose is to handle these special cases of argv[0]: * Invoked using python -m ... * Invoked using a path to the executable even though the executable is on the PATH This change enhances the path comparison to support normalization of that path, Windows long path prefixes, and also the easy-install behavior on Windows where argv[0] has no extension. Yet to be properly handled is invocation using python -c ...
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #617 +/- ##
==========================================
+ Coverage 83.27% 83.33% +0.06%
==========================================
Files 66 66
Lines 3857 3865 +8
Branches 762 763 +1
==========================================
+ Hits 3212 3221 +9
+ Misses 556 555 -1
Partials 89 89 ☔ View full report in Codecov by Sentry. |
I think we could test at least some of it. Much of the behavior we're working around is specific to easy-install and Windows, but I might be able to specifically test the mechanics in some tests. I'll add something to this PR. |
Added a bunch of tests, and found a bug 🙃 |
|
I had this at 100% test coverage locally, but it doesn't appear that codecov is correctly merging the results and reports a single missed line that is covered only on the Windows builds. I confirmed that the data that codecov is getting indicates coverage of the line, but the dashboard still reports it missing. Obnoxious but not a problem. |
This function's purpose is to handle these special cases of argv[0]:
This change enhances the path comparison to support normalization of the paths, Windows long path prefixes, and also the easy-install behavior on Windows where argv[0] has no extension.
Yet to be properly handled is invocation using python -c ...