Extract and explicitly pass install-scripts to setuptools #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When part of a virtual environment, this option is specifically ignored in configuration files by setuptools, but not on the command line.
cottsay
force-pushed
the
cottsay/venvs
branch
from
7537ae7
to
6b88238
Compare
Codecov ReportBase: 81.66% // Head: 81.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #530 +/- ##
==========================================
- Coverage 81.66% 81.48% -0.18%
==========================================
Files 60 58 -2
Lines 3566 3375 -191
Branches 685 657 -28
==========================================
- Hits 2912 2750 -162
+ Misses 602 579 -23
+ Partials 52 46 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cottsay
force-pushed
the
cottsay/venvs
branch
from
6b88238
to
30b6be6
Compare
j-rivero
approved these changes
Nov 7, 2022
ivanpauno
approved these changes
Nov 8, 2022
nuclearsandwich
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When part of a virtual environment, this option is specifically ignored in configuration files by setuptools, but not on the command line.
This is an actual fix for #518, which wasn't actually fixed by #520 but rather made it far less common.
The test added here doesn't actually create a virtual environment to validate the conditions which motivated this fix, but the test will fail if run under a virtual environment without this fix.