Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception output #329

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Exception output #329

wants to merge 2 commits into from

Conversation

rotu
Copy link
Contributor

@rotu rotu commented Mar 25, 2020

Use logger.exception to format current traceback in an error

Use logger.exception to format current traceback in an error
@dirk-thomas dirk-thomas added the in progress Actively being worked on (Kanban column) label Mar 27, 2020
@dirk-thomas
Copy link
Member

@rotu Friendly ping.

@rotu rotu marked this pull request as draft April 14, 2020 17:48
@rotu
Copy link
Contributor Author

rotu commented Apr 14, 2020

Oof. I dropped the ball here; converting to a draft. BTW, do you have a preference between logger.exception(msg) versus logger.error(msg, exc_info=True)?

@dirk-thomas
Copy link
Member

do you have a preference between logger.exception(msg) versus logger.error(msg, exc_info=True)?

Within an except I would lean toward the former since that is exactly what that method is supposed to be used for.

@dirk-thomas dirk-thomas changed the title WIP: Exception output Exception output Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Actively being worked on (Kanban column)
Development

Successfully merging this pull request may close these issues.

None yet

2 participants