Rework Package identification tests

[rotu]

Package identifications test was doing way too much in one test to follow.
Split into multiple, more targeted tests and added some additional coverage

[codecov-io]

Codecov Report

Merging #229 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
- Coverage   79.50%   79.32%   -0.19%     
==========================================
  Files          55       55              
  Lines        3221     3221              
  Branches      535      535              
==========================================
- Hits         2561     2555       -6     
- Misses        613      617       +4     
- Partials       47       49       +2     

Impacted Files	Coverage Δ
colcon_core/package_identification/python.py	78.16% <0.00%> (-6.90%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 165c033...04713ee. Read the comment docs.

[dirk-thomas]

In the current state the patch reduced test coverage in some part of the code.

[dirk-thomas]

@rotu Friendly ping.

[rotu]

Thanks for the ping.
The coverage dip is due to the xfail on test_re_identify_python_if_different_python_package. That's the downside of breaking this up into two PRs.

[rotu]

@dirk-thomas Friendly ping.

[dirk-thomas]

Thanks for improving the tests.

I will just wait for clicking merge until #215 is good to be merged (to avoid the temporary drop of coverage between them).

[dirk-thomas]

Please rebase / resolve conflict to be able to re-review and merge this patch.

[dirk-thomas]

@rotu Please rebase this branch in a way that the pull requests only shows commits related to this change.

[rotu]

@rotu Please rebase this branch in a way that the pull requests only shows commits related to this change.

Oops. Nothing like rebasing on the wrong master. Blech. Let me try one more time...

Success!