Support thread interruption while decoding. #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrtwhite
commented
May 23, 2020
| message = "This is an internal Coil API that should not be used from outside of the `coil` package. " + | ||
| "No compatibility guarantees are provided." | ||
| ) | ||
| annotation class InternalCoilApi |
There was a problem hiding this comment.
This is necessary to avoid duplicating the interruption code in coil-gif and coil-svg. Maybe withInterruptibleSource can be public API one day, but probably doesn't make sense.
colinrtwhite
force-pushed
the
colin/thread_interruption
branch
from
ddcdce1
to
70ade86
Compare
Jawnnypoo
approved these changes
May 26, 2020
|
@Jawnnypoo Ran the change through my benchmarking project and wasn't able to measure a change with enough accuracy so I'd say it has almost no decode time overhead. |
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
* Support thread interruption while decoding. * Update API. * Handle InterruptedIOException as well. * Add test. * Reduce delay. * Docs. * Replace AtomicInteger with atomicfu. * Add to tests as well. * Updates. * Revert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #378
An initial attempt at supporting thread interruption while decoding.
The implementation is based on
runInterruptiblefrom the Coroutines library. The main difference is we need to prevent interruption while reading from aSourcedue to this reason.I didn't add interruption support to
VideoFrameFetcheras it seems like even if we interrupt the thread subsequent requests still seem to wait for the previous request to finish. This is likely a hardware limitation.TODO: Benchmark this to see how much overheadAccording to my benchmark it adds negligible (too small to measure) overhead to decoding. In the typical case we're getting and setting a volatile int <20 times which is very fast.InterruptionSourceadds.