-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the Series and Collection data flow #302
Commits on May 5, 2019
-
Refactor the Series and Collection data flow
Simplify a lot of the logic in DataProvider by inverting the source of truth for Series and Collections. This change moves them from immutable props on DataProvider to separate children components which report their configuration (through the DataProvider's Context) into DataProvider's state. This allows DataProvider to be responsible for watching a lot fewer props and move the logic out to the separate components. Additionally, this ensures that the properties for Series and Collection are centrally-documented, due to them using TypeScript for their implementations. This also comes with some nice syntactic sugar around the grouping of Series into Collections (however, this is not required). Another benefit of this cleaned system is that the system can guarantee that Series and Collection objects which leave DataProvider are fully-populated. This will allow us to clean up default props littered throughout the codebase, for things like strokeWidth and color. Finally, in order to ease this massively-breaking API change, a thin backwards-compatibility shim has been introduced into DataProvider. However, this is not intended to be permanent and should be removed before the 0.5.0 stable version is released.
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 101d9d2 - Browse repository at this point
Copy the full SHA 101d9d2View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 630f904 - Browse repository at this point
Copy the full SHA 630f904View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for d8bd830 - Browse repository at this point
Copy the full SHA d8bd830View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for ff21019 - Browse repository at this point
Copy the full SHA ff21019View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for d21469f - Browse repository at this point
Copy the full SHA d21469fView commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for e515289 - Browse repository at this point
Copy the full SHA e515289View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for ea53ed5 - Browse repository at this point
Copy the full SHA ea53ed5View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 09e96f9 - Browse repository at this point
Copy the full SHA 09e96f9View commit details -
Moved the Collection/Series stories
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 3e98fd6 - Browse repository at this point
Copy the full SHA 3e98fd6View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 35f26e6 - Browse repository at this point
Copy the full SHA 35f26e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d59962 - Browse repository at this point
Copy the full SHA 6d59962View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 9195608 - Browse repository at this point
Copy the full SHA 9195608View commit details -
Ported min/max with raw points
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 5137349 - Browse repository at this point
Copy the full SHA 5137349View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for bcb8748 - Browse repository at this point
Copy the full SHA bcb8748View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 1422fef - Browse repository at this point
Copy the full SHA 1422fefView commit details -
Custom default accessors working
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 98a5cc5 - Browse repository at this point
Copy the full SHA 98a5cc5View commit details -
This required moving the calculated domains into the state
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 0286a43 - Browse repository at this point
Copy the full SHA 0286a43View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for c55357f - Browse repository at this point
Copy the full SHA c55357fView commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 2acce3f - Browse repository at this point
Copy the full SHA 2acce3fView commit details -
Port drawPoints / add default drawPoints
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 789cf75 - Browse repository at this point
Copy the full SHA 789cf75View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 196c508 - Browse repository at this point
Copy the full SHA 196c508View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for bb697a2 - Browse repository at this point
Copy the full SHA bb697a2View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for f95a773 - Browse repository at this point
Copy the full SHA f95a773View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for cb4a843 - Browse repository at this point
Copy the full SHA cb4a843View commit details -
This leads to a crash if there aren't any series at all. Will fix later.
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for c82a63d - Browse repository at this point
Copy the full SHA c82a63dView commit details -
Sticky time subdomain -- FIXME
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 9e841e7 - Browse repository at this point
Copy the full SHA 9e841e7View commit details -
Port sticky subdomain and ruler -- FIXME
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for e92ad82 - Browse repository at this point
Copy the full SHA e92ad82View commit details -
Port limit timesubdomain -- FIXME
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 93f86e5 - Browse repository at this point
Copy the full SHA 93f86e5View commit details -
Port limit time subdomain -- FIXME
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 39150bd - Browse repository at this point
Copy the full SHA 39150bdView commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for d15a7ab - Browse repository at this point
Copy the full SHA d15a7abView commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for c696d0d - Browse repository at this point
Copy the full SHA c696d0dView commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for a3c7e12 - Browse repository at this point
Copy the full SHA a3c7e12View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 0dec119 - Browse repository at this point
Copy the full SHA 0dec119View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for e833cee - Browse repository at this point
Copy the full SHA e833ceeView commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for c0c3d2d - Browse repository at this point
Copy the full SHA c0c3d2dView commit details -
Remove some copy/paste boilerplate
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for ae4ecdc - Browse repository at this point
Copy the full SHA ae4ecdcView commit details -
Ordering of Series props doesn't matter
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 3623fb2 - Browse repository at this point
Copy the full SHA 3623fb2View commit details -
Remove unused DataProvider code
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 2f397ea - Browse repository at this point
Copy the full SHA 2f397eaView commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 191e7ab - Browse repository at this point
Copy the full SHA 191e7abView commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 6484762 - Browse repository at this point
Copy the full SHA 6484762View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 357db35 - Browse repository at this point
Copy the full SHA 357db35View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 450454a - Browse repository at this point
Copy the full SHA 450454aView commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 22f3956 - Browse repository at this point
Copy the full SHA 22f3956View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for f876a45 - Browse repository at this point
Copy the full SHA f876a45View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 600db42 - Browse repository at this point
Copy the full SHA 600db42View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 85495dc - Browse repository at this point
Copy the full SHA 85495dcView commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for b7e9e65 - Browse repository at this point
Copy the full SHA b7e9e65View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 532ba10 - Browse repository at this point
Copy the full SHA 532ba10View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for f3b6f47 - Browse repository at this point
Copy the full SHA f3b6f47View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 9dcd84b - Browse repository at this point
Copy the full SHA 9dcd84bView commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for defba08 - Browse repository at this point
Copy the full SHA defba08View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for ae4700b - Browse repository at this point
Copy the full SHA ae4700bView commit details -
Things went sideways with the domains, but I think I properly fixed it for real in the Scaler. I hope.
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 4c0d305 - Browse repository at this point
Copy the full SHA 4c0d305View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 0635561 - Browse repository at this point
Copy the full SHA 0635561View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for fb1da45 - Browse repository at this point
Copy the full SHA fb1da45View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 0274580 - Browse repository at this point
Copy the full SHA 0274580View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 7615822 - Browse repository at this point
Copy the full SHA 7615822View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for af0cafd - Browse repository at this point
Copy the full SHA af0cafdView commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for a9e7561 - Browse repository at this point
Copy the full SHA a9e7561View commit details -
Ported InteractionLayer stories
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for dcae6e2 - Browse repository at this point
Copy the full SHA dcae6e2View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for f984f9a - Browse repository at this point
Copy the full SHA f984f9aView commit details -
Ported XAxisPlacements stories
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 87bbc30 - Browse repository at this point
Copy the full SHA 87bbc30View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for f443a2d - Browse repository at this point
Copy the full SHA f443a2dView commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 3aa643d - Browse repository at this point
Copy the full SHA 3aa643dView commit details -
Ported SeriesCollection stories
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 6b5753c - Browse repository at this point
Copy the full SHA 6b5753cView commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 7246909 - Browse repository at this point
Copy the full SHA 7246909View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 9729a2e - Browse repository at this point
Copy the full SHA 9729a2eView commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 4b1cd62 - Browse repository at this point
Copy the full SHA 4b1cd62View commit details -
Added toggles to the Collection stories
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for f07208b - Browse repository at this point
Copy the full SHA f07208bView commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 5ec6a3d - Browse repository at this point
Copy the full SHA 5ec6a3dView commit details -
Support legacy rendering (for now)
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 18acdc8 - Browse repository at this point
Copy the full SHA 18acdc8View commit details -
Evan Charlton committed
May 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 7456e60 - Browse repository at this point
Copy the full SHA 7456e60View commit details -
Add proptype for legacy collections
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 2b5c344 - Browse repository at this point
Copy the full SHA 2b5c344View commit details -
Make TypeScript happy with Collection
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for b7889e0 - Browse repository at this point
Copy the full SHA b7889e0View commit details -
Document (or remove) @ts-ignore wherever possible.
Evan Charlton committedMay 5, 2019 Configuration menu - View commit details
-
Copy full SHA for f36dc2d - Browse repository at this point
Copy the full SHA f36dc2dView commit details
Commits on May 6, 2019
-
Clean up the "Change props" stories a bit
Evan Charlton committedMay 6, 2019 Configuration menu - View commit details
-
Copy full SHA for dd8e28e - Browse repository at this point
Copy the full SHA dd8e28eView commit details -
Make the arrays a bit prettier
Because hey what's another commit on this branch, right?
Evan Charlton committedMay 6, 2019 Configuration menu - View commit details
-
Copy full SHA for d7a929a - Browse repository at this point
Copy the full SHA d7a929aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e8445c - Browse repository at this point
Copy the full SHA 5e8445cView commit details -
Add comments about the placeholder domains
Evan Charlton committedMay 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 865a630 - Browse repository at this point
Copy the full SHA 865a630View commit details -
Merge branch 'master' of github.com:cognitedata/griff-react into seri…
…es-data-flow
Evan Charlton committedMay 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 5301735 - Browse repository at this point
Copy the full SHA 5301735View commit details -
Add displayNames to Series / Collection
Evan Charlton committedMay 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 84792cc - Browse repository at this point
Copy the full SHA 84792ccView commit details -
Pull out the series toggler thing
It should be shared between Series and Collection
Evan Charlton committedMay 6, 2019 Configuration menu - View commit details
-
Copy full SHA for fe7a22f - Browse repository at this point
Copy the full SHA fe7a22fView commit details -
Evan Charlton committed
May 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 26ec34a - Browse repository at this point
Copy the full SHA 26ec34aView commit details -
Added basic stories for Scatterplots
These are already covered by the Scatterplot stories but hey here we go
Evan Charlton committedMay 6, 2019 Configuration menu - View commit details
-
Copy full SHA for b58b7c1 - Browse repository at this point
Copy the full SHA b58b7c1View commit details
Commits on May 7, 2019
-
Merge branch 'master' of github.com:cognitedata/griff-react into seri…
…es-data-flow
Evan Charlton committedMay 7, 2019 Configuration menu - View commit details
-
Copy full SHA for 4fb5c14 - Browse repository at this point
Copy the full SHA 4fb5c14View commit details -
This required an update to Scaler where we need to handle the series props changing because they come in late.
Evan Charlton committedMay 7, 2019 Configuration menu - View commit details
-
Copy full SHA for af89c96 - Browse repository at this point
Copy the full SHA af89c96View commit details -
Evan Charlton committed
May 7, 2019 Configuration menu - View commit details
-
Copy full SHA for 0dac5c5 - Browse repository at this point
Copy the full SHA 0dac5c5View commit details