Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Series and Collection data flow #302

Merged
merged 87 commits into from
May 8, 2019
Merged

Commits on May 5, 2019

  1. Refactor the Series and Collection data flow

    Simplify a lot of the logic in DataProvider by inverting the source of
    truth for Series and Collections. This change moves them from immutable
    props on DataProvider to separate children components which report their
    configuration (through the DataProvider's Context) into DataProvider's
    state. This allows DataProvider to be responsible for watching a lot
    fewer props and move the logic out to the separate components.
    
    Additionally, this ensures that the properties for Series and Collection
    are centrally-documented, due to them using TypeScript for their
    implementations. This also comes with some nice syntactic sugar around
    the grouping of Series into Collections (however, this is not required).
    
    Another benefit of this cleaned system is that the system can guarantee
    that Series and Collection objects which leave DataProvider are
    fully-populated. This will allow us to clean up default props littered
    throughout the codebase, for things like strokeWidth and color.
    
    Finally, in order to ease this massively-breaking API change, a thin
    backwards-compatibility shim has been introduced into DataProvider.
    However, this is not intended to be permanent and should be removed
    before the 0.5.0 stable version is released.
    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    101d9d2 View commit details
    Browse the repository at this point in the history
  2. Remove a bunch of unused code

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    630f904 View commit details
    Browse the repository at this point in the history
  3. Added collections

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    d8bd830 View commit details
    Browse the repository at this point in the history
  4. Added ySubDomain

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    ff21019 View commit details
    Browse the repository at this point in the history
  5. Added hidden

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    d21469f View commit details
    Browse the repository at this point in the history
  6. Add loader

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    e515289 View commit details
    Browse the repository at this point in the history
  7. Ported sized

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    ea53ed5 View commit details
    Browse the repository at this point in the history
  8. Ported Full-size

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    09e96f9 View commit details
    Browse the repository at this point in the history
  9. Moved the Collection/Series stories

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    3e98fd6 View commit details
    Browse the repository at this point in the history
  10. Ported resizing

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    35f26e6 View commit details
    Browse the repository at this point in the history
  11. Added min/max support

    custom accessor support is coming
    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    6d59962 View commit details
    Browse the repository at this point in the history
  12. Add step

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    9195608 View commit details
    Browse the repository at this point in the history
  13. Ported min/max with raw points

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    5137349 View commit details
    Browse the repository at this point in the history
  14. Ported loading data from API

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    bcb8748 View commit details
    Browse the repository at this point in the history
  15. Add hidden

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    1422fef View commit details
    Browse the repository at this point in the history
  16. Custom default accessors working

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    98a5cc5 View commit details
    Browse the repository at this point in the history
  17. Port over specified y domains

    This required moving the calculated domains into the state
    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    0286a43 View commit details
    Browse the repository at this point in the history
  18. Ported Annotation

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    c55357f View commit details
    Browse the repository at this point in the history
  19. Ported click events

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    2acce3f View commit details
    Browse the repository at this point in the history
  20. Port drawPoints / add default drawPoints

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    789cf75 View commit details
    Browse the repository at this point in the history
  21. Port without context chart

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    196c508 View commit details
    Browse the repository at this point in the history
  22. Add zoomable

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    bb697a2 View commit details
    Browse the repository at this point in the history
  23. Add ySubDomain

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    f95a773 View commit details
    Browse the repository at this point in the history
  24. Port dyanmic time subdomain

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    cb4a843 View commit details
    Browse the repository at this point in the history
  25. Port enable/disable series

    This leads to a crash if there aren't any series at all. Will fix later.
    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    c82a63d View commit details
    Browse the repository at this point in the history
  26. Sticky time subdomain -- FIXME

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    9e841e7 View commit details
    Browse the repository at this point in the history
  27. Port sticky subdomain and ruler -- FIXME

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    e92ad82 View commit details
    Browse the repository at this point in the history
  28. Port limit timesubdomain -- FIXME

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    93f86e5 View commit details
    Browse the repository at this point in the history
  29. Port limit time subdomain -- FIXME

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    39150bd View commit details
    Browse the repository at this point in the history
  30. Port onMouseOut

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    d15a7ab View commit details
    Browse the repository at this point in the history
  31. Port onUpdaetDomains

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    c696d0d View commit details
    Browse the repository at this point in the history
  32. Starting on Scatterplots

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    a3c7e12 View commit details
    Browse the repository at this point in the history
  33. Add live loading

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    0dec119 View commit details
    Browse the repository at this point in the history
  34. Port live loading with ruler

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    e833cee View commit details
    Browse the repository at this point in the history
  35. Remove old series prop

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    c0c3d2d View commit details
    Browse the repository at this point in the history
  36. Remove some copy/paste boilerplate

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    ae4ecdc View commit details
    Browse the repository at this point in the history
  37. Ordering of Series props doesn't matter

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    3623fb2 View commit details
    Browse the repository at this point in the history
  38. Remove unused DataProvider code

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    2f397ea View commit details
    Browse the repository at this point in the history
  39. Ported Basic Usage

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    191e7ab View commit details
    Browse the repository at this point in the history
  40. Port different domains

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    6484762 View commit details
    Browse the repository at this point in the history
  41. Port domains

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    357db35 View commit details
    Browse the repository at this point in the history
  42. Port custom tick formatting

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    450454a View commit details
    Browse the repository at this point in the history
  43. Port grid

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    22f3956 View commit details
    Browse the repository at this point in the history
  44. Port axes

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    f876a45 View commit details
    Browse the repository at this point in the history
  45. Port split axes

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    600db42 View commit details
    Browse the repository at this point in the history
  46. Port strokeWidth & pointWidth

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    85495dc View commit details
    Browse the repository at this point in the history
  47. Ported opacity

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    b7e9e65 View commit details
    Browse the repository at this point in the history
  48. Port min/max

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    532ba10 View commit details
    Browse the repository at this point in the history
  49. Port context chart

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    f3b6f47 View commit details
    Browse the repository at this point in the history
  50. Port zoomable

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    9dcd84b View commit details
    Browse the repository at this point in the history
  51. Port drawLines

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    defba08 View commit details
    Browse the repository at this point in the history
  52. Port pointRenderer

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    ae4700b View commit details
    Browse the repository at this point in the history
  53. Fix scatterplot zooming

    Things went sideways with the domains, but I think I properly fixed it
    for real in the Scaler. I hope.
    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    4c0d305 View commit details
    Browse the repository at this point in the history
  54. Removing old APIs

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    0635561 View commit details
    Browse the repository at this point in the history
  55. Ported dynamic time domain

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    fb1da45 View commit details
    Browse the repository at this point in the history
  56. Ported AxisCollection stories

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    0274580 View commit details
    Browse the repository at this point in the history
  57. Ported ContextChart stories

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    7615822 View commit details
    Browse the repository at this point in the history
  58. Ported GridLines stories

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    af0cafd View commit details
    Browse the repository at this point in the history
  59. Ported Plotly stories

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    a9e7561 View commit details
    Browse the repository at this point in the history
  60. Ported InteractionLayer stories

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    dcae6e2 View commit details
    Browse the repository at this point in the history
  61. Port XAxis stories

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    f984f9a View commit details
    Browse the repository at this point in the history
  62. Ported XAxisPlacements stories

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    87bbc30 View commit details
    Browse the repository at this point in the history
  63. Ported YAxisModes stories

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    f443a2d View commit details
    Browse the repository at this point in the history
  64. Ported YAxisPlacement stories

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    3aa643d View commit details
    Browse the repository at this point in the history
  65. Ported SeriesCollection stories

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    6b5753c View commit details
    Browse the repository at this point in the history
  66. Remove series prop

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    7246909 View commit details
    Browse the repository at this point in the history
  67. Clean up DataProvider a bit

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    9729a2e View commit details
    Browse the repository at this point in the history
  68. Added opacity to line

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    4b1cd62 View commit details
    Browse the repository at this point in the history
  69. Added toggles to the Collection stories

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    f07208b View commit details
    Browse the repository at this point in the history
  70. Extract prop names

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    5ec6a3d View commit details
    Browse the repository at this point in the history
  71. Support legacy rendering (for now)

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    18acdc8 View commit details
    Browse the repository at this point in the history
  72. Clean up eslint warnings

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    7456e60 View commit details
    Browse the repository at this point in the history
  73. Add proptype for legacy collections

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    2b5c344 View commit details
    Browse the repository at this point in the history
  74. Make TypeScript happy with Collection

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    b7889e0 View commit details
    Browse the repository at this point in the history
  75. Document (or remove) @ts-ignore wherever possible.

    Evan Charlton committed May 5, 2019
    Configuration menu
    Copy the full SHA
    f36dc2d View commit details
    Browse the repository at this point in the history

Commits on May 6, 2019

  1. Clean up the "Change props" stories a bit

    Evan Charlton committed May 6, 2019
    Configuration menu
    Copy the full SHA
    dd8e28e View commit details
    Browse the repository at this point in the history
  2. Make the arrays a bit prettier

    Because hey what's another commit on this branch, right?
    Evan Charlton committed May 6, 2019
    Configuration menu
    Copy the full SHA
    d7a929a View commit details
    Browse the repository at this point in the history
  3. Fix the Plotly story

    Lordy.
    Evan Charlton committed May 6, 2019
    Configuration menu
    Copy the full SHA
    5e8445c View commit details
    Browse the repository at this point in the history
  4. Add comments about the placeholder domains

    Evan Charlton committed May 6, 2019
    Configuration menu
    Copy the full SHA
    865a630 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'master' of github.com:cognitedata/griff-react into seri…

    …es-data-flow
    Evan Charlton committed May 6, 2019
    Configuration menu
    Copy the full SHA
    5301735 View commit details
    Browse the repository at this point in the history
  6. Add displayNames to Series / Collection

    Evan Charlton committed May 6, 2019
    Configuration menu
    Copy the full SHA
    84792cc View commit details
    Browse the repository at this point in the history
  7. Pull out the series toggler thing

    It should be shared between Series and Collection
    Evan Charlton committed May 6, 2019
    Configuration menu
    Copy the full SHA
    fe7a22f View commit details
    Browse the repository at this point in the history
  8. Make the borders align

    Evan Charlton committed May 6, 2019
    Configuration menu
    Copy the full SHA
    26ec34a View commit details
    Browse the repository at this point in the history
  9. Added basic stories for Scatterplots

    These are already covered by the Scatterplot stories but hey here we go
    Evan Charlton committed May 6, 2019
    Configuration menu
    Copy the full SHA
    b58b7c1 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2019

  1. Merge branch 'master' of github.com:cognitedata/griff-react into seri…

    …es-data-flow
    Evan Charlton committed May 7, 2019
    Configuration menu
    Copy the full SHA
    4fb5c14 View commit details
    Browse the repository at this point in the history
  2. Fix the ChartJS stories

    This required an update to Scaler where we need to handle the series
    props changing because they come in late.
    Evan Charlton committed May 7, 2019
    Configuration menu
    Copy the full SHA
    af89c96 View commit details
    Browse the repository at this point in the history
  3. Rework stripPlaceholderDomain

    Evan Charlton committed May 7, 2019
    Configuration menu
    Copy the full SHA
    0dac5c5 View commit details
    Browse the repository at this point in the history