Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(plugin): add tests to prevent some regressions #419

Merged
merged 1 commit into from Jun 10, 2019
Merged

Conversation

ryanclark
Copy link
Collaborator

@ryanclark ryanclark commented Jun 7, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Quickly add some tests to prevent regressions like #418 from happening again (this will fail CI until that PR is merged)

@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #419 into master will increase coverage by 1.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
+ Coverage   40.63%   42.46%   +1.82%     
==========================================
  Files           3        3              
  Lines         219      219              
  Branches       48       48              
==========================================
+ Hits           89       93       +4     
+ Misses        107      103       -4     
  Partials       23       23
Impacted Files Coverage Δ
src/karma-webpack.js 46.96% <0%> (+2.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48878eb...dfe0d78. Read the comment docs.

@ryanclark ryanclark merged commit 3cc35b3 into master Jun 10, 2019
@ryanclark ryanclark deleted the add-tests branch June 10, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants