Improve type annotations #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the floating-point division in the ratio calculation with Fraction
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
===========================================
+ Coverage 99.34% 100.00% +0.65%
===========================================
Files 13 13
Lines 459 464 +5
===========================================
+ Hits 456 464 +8
+ Misses 3 0 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codingjoe
approved these changes
May 4, 2024
codingjoe
changed the title
codingjoe
pushed a commit
that referenced
this pull request
May 5, 2024
* Change ratio calculation to use Fraction Replace the floating-point division in the ratio calculation with Fraction * Refine type annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
container_width: int = Nonewas causing issues with my type checking, so I updated it tocontainer_width: int | None = None.**breakpointsas described in the argument lists section of PEP 484.ratio = ratio or (img_width / img_height)assigns a floating-point number, which disrupts type checking.