Update PictureField to support multiple aspect_ratios and file_types #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingjoe
force-pushed
the
rename-attr
branch
from
7eb1693
to
71f9e84
Compare
amureki
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Lovely! Thanks for cleaning this up 👍
Performance-wise it is similar to what was before. I wonder if we can make it faster, but it is good enough for now.
We'd need to fix the documentation as well.
https://github.com/codingjoe/django-pictures?tab=readme-ov-file#django-rest-framework-drf
codingjoe
force-pushed
the
rename-attr
branch
from
71f9e84
to
853d89f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amureki can you verify that this is still meeting your performance requirements?
I also noticed some naming inconsistencies in terms of keywords.