fix: conflict between core-js and bfs-process #6136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeMoorJasper
commented
Sep 14, 2021
| @@ -40,6 +40,11 @@ export default function ( | |||
| delete allGlobals.global; | |||
| } | |||
|
|
|||
| // This is a hack to make core-js work... | |||
| if (window.process.versions) { | |||
There was a problem hiding this comment.
This is a pretty big hack, see the PR description for better (bigger) solutions/refactors
|
Build for latest commit d93eae8 is at https://pr6136.build.csb.dev/s/new. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d93eae8:
|
CompuIves
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR fixes an issue with core-js and bfs-process conflicting.
We definitely need to have a look at how to prevent all the global scope poluting we (and mainly browser-fs) does though, as these bugs can be prevented pretty easily that way.
Also probably a good idea to revisit the eval code at some point as it also has some weird behaviour with core-js, specifically this line: https://github.com/zloirock/core-js/blob/master/packages/core-js/internals/global.js#L2
Also this one for detecting v8 engine using the nodeJS path: https://github.com/zloirock/core-js/blob/master/packages/core-js/internals/engine-v8-version.js
Closes #5943