New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core-js >=3.12 throws errors Target is not iterable
#5943
Comments
Maybe this is a combination of package versions because every version of core-js I try is broken with that error |
Nevermind, I wasn't hitting refresh every time. Confirmed it is broken since 3.12.0 |
Hi, Any news? |
Hi @smhutch, I hope this finds you well. Could you provide a brief update on this issue? |
From this version, |
The thing which confuses me is that it actually works locally with the same setup, or on stackblitz. The only place where I see this error is codesandbox. |
@DeMoorJasper can you please take a look at this? |
Seems to work fine to me, can somebody create a reproduction? |
@DeMoorJasper https://codesandbox.io/s/jovial-hawking-lx4oy (just change "core-js": "3.12.0", in package.json from angular template as in the first post said) |
@DeMoorJasper, I would assume you forgot to refresh the builtin browser manually. |
@babich-a Thank you I can reproduce it now, will look into (and hopefully fix) it tomorrow |
Hi @DeMoorJasper, could you provide an update on the issue? |
@satanTime looking into it today, something came up preventing me from looking into this sooner. Found the issue, it's due to
Hacked around it and opened a PR, will put it in production once the tests pass |
Hi @zloirock should we create an issue in
|
@satanTime the problem is that NodeJS also could emulate browser environment. We couldn't just stop check the V8 version in feature detection because it will cause a critical slowdown (100x+) in some cases even if nothing is polyfilled because of V8 whims like this. I'll try to add a workaround, but mainly it should be fixed on NodeJS polyfills side - it's their bug - |
…correctly reports V8 version that's used in some cases of `core-js` feature detection jvilk/bfs-process#5 codesandbox/codesandbox-client#5943
It seems core-js@3.19.1 has a fix for this problem. @zloirock can you confirm? |
Yes, I added a workaround for this |
Thank you for fixing this @zloirock 🙏 will close this issue |
@DeMoorJasper it could be better to specify the actual |
🐛 bug report
Preflight Checklist
adheres to.
to file, without success.
Description of the problem
Local usage of
core-js >= 3.12
doesn't have issues, whereascodesandbox
throwsTarget is not iterable
.How has this issue affected you? What are you trying to accomplish?
I try to keep dependencies up to date.
To Reproduce
Angular angular-cli
dependencies
the version ofcore-js
to3.11.3
dependencies
the version ofcore-js
to3.12.0
if you download the project and run it locally, it works correctly.
The text was updated successfully, but these errors were encountered: