New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update golang to 1.18 and k8s to 0.24.2 #629
Conversation
with: | ||
version: v1.43.0 | ||
skip-go-installation: true # we already installed Go with `actions/setup-go@v2` above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any reason for removing the skip-go-installation
flag here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seem like since v3 they are not installing go anymore by default v3 PR
go.mod
Outdated
|
||
replace ( | ||
github.com/codeready-toolchain/api v0.0.0-20221121081259-4f672e808b89 => github.com/ranakan19/api v0.0.0-20221201091806-57fc665ce345 | ||
github.com/codeready-toolchain/toolchain-common v0.0.0-20221124073251-2d6d8cbd5eb7 => github.com/ranakan19/toolchain-common v0.0.0-20221201182049-e9ceb160687f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
friendly reminder!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MatousJobanek, mfrancisc, ranakan19, xcoulon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
/test e2e |
No description provided.