Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: audit, deploymentconfig, files, parameters #5506

Merged
merged 7 commits into from
Jan 3, 2023
Merged

docs: audit, deploymentconfig, files, parameters #5506

merged 7 commits into from
Jan 3, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Dec 22, 2022 •
edited

Related: #3522

Changes:

  • docs: audit, deploymentconfig, files, parameters
  • fix: /templates/{id} [patch]
  • fix: user swaggertype to replace NullTime with string
  • fix: do not print authentication undefined if the endpoint doesn't require auth

@mtojek mtojek self-assigned this Dec 22, 2022
@mtojek mtojek changed the title docs: TBD docs: audit, deploymentconfig, files, parameters Dec 22, 2022
@mtojek mtojek marked this pull request as ready for review December 22, 2022 15:16
@mtojek mtojek force-pushed the 3522-document-more-methods-3 branch from 2063d0c to a3fbe72 Compare December 22, 2022 15:36
This was referenced Jan 2, 2023
Closed
Merged
mafredri
mafredri approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍, only had some minor comments/questions.

docs/api/files.md Outdated Show resolved Hide resolved
docs/api/files.md Outdated Show resolved Hide resolved
docs/api/parameters.md Outdated Show resolved Hide resolved
docs/api/parameters.md Outdated Show resolved Hide resolved
codersdk/workspacebuilds.go Outdated Show resolved Hide resolved
@mtojek mtojek merged commit e67d131 into coder:main Jan 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@bpmct bpmct bpmct approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mtojek @mafredri @bpmct