Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(coderd): add endpoints for editing and deleting organizations #13287

Merged
merged 28 commits into from
May 21, 2024
Merged

feat(coderd): add endpoints for editing and deleting organizations #13287

merged 28 commits into from
May 21, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented May 15, 2024 •
edited

Add backend and codersdk support for editing and deleting organizations

  • PATCH /api/v2/organizations/:orgId for updating an existing org
  • DELETE /api/v2/organizations/:orgId for deleting an org
  • codersdk.Client.UpdateOrganization to match the new PATCH endpoint
  • codersdk.Client.DeleteOrganization to match the new DELETE endpoint
  • also codersdk.Client.CreateOrganization, because it was missing

@aslilac aslilac requested a review from Emyrk May 16, 2024 19:09
@aslilac aslilac marked this pull request as ready for review May 16, 2024 19:09
Emyrk
Emyrk requested changes May 16, 2024
View reviewed changes
.vscode/settings.json Show resolved Hide resolved
coderd/database/dbauthz/dbauthz_test.go Outdated Show resolved Hide resolved
coderd/database/dbauthz/dbauthz_test.go Outdated Show resolved Hide resolved
coderd/database/dbmem/dbmem.go Outdated Show resolved Hide resolved
coderd/database/dbmem/dbmem.go Outdated Show resolved Hide resolved
coderd/database/queries/organizations.sql Outdated Show resolved Hide resolved
coderd/organizations.go Outdated Show resolved Hide resolved
coderd/organizations.go Outdated Show resolved Hide resolved
coderd/organizations_test.go Outdated Show resolved Hide resolved
scripts/rbacgen/main.go Outdated Show resolved Hide resolved
@aslilac aslilac requested a review from Emyrk May 17, 2024 17:59
@aslilac
Copy link
Member Author

aslilac commented May 17, 2024 •
edited

So, it turns out there isn't actually a unique constraint on organization names. I'm adding that in #13311, and will rebase this once that gets merged.

Update: done

@aslilac aslilac merged commit 3f1e9c0 into main May 21, 2024
36 checks passed
@aslilac aslilac deleted the edit-and-delete-orgs branch May 21, 2024 18:46
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Emyrk Emyrk Emyrk approved these changes

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aslilac @Emyrk