Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/google/go-cmp from 0.4.0 to 0.5.5 #266

Merged
merged 2 commits into from Mar 11, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 6, 2021

Bumps github.com/google/go-cmp from 0.4.0 to 0.5.5.

Release notes

Sourced from github.com/google/go-cmp's releases.

v0.5.5

Bug fixes:

  • (#253) Fix reporter verbosity bug

Reporter changes:

  • (#254) De-virtualize interfaces for specialized diffing

Dependency changes:

  • (#251) Use errors.Is with ≥go1.13 in compareErrors

v0.5.4

Bug fixes:

(#247) Fix non-determinism in diffing algorithm (#248) Impose verbosity limit when formatting map keys

v0.5.3

Minor documentation changes:

(#236) Fix license headers (#205) Add an example for IgnoreFields (#237) Fix Diff documentation

v0.5.2

Minor documentation changes:

(#234) Suggest use of cmpopts.EquateErrors (#231) Fix Diff documentation

v0.5.1

Minor reporter changes:

  • (#221) Swallow panics when calling String or Error methds.
  • (#229) Use triple-quote formatting for multiline strings in diffs.

Minor documentation changes:

  • (#228) Adjust panic for IgnoreUnexported and IgnoreFields to be more specific.

v0.5.0

The most notable changes in this release are improvements to the reporter output (i.e., the implementation that produces output for Diff). The changes seek to improve the signal-to-noise ratio such that differences of interest to the user are emphasized, while information that is less relevant are de-emphasized.

The reporter largely consists of a set of heuristics to determine what would be the best way to format the difference in the common case. If the output seems sub-par, please file an issue. The reports are highly valuable in improving its output (e.g., #195, #194, #202, #185).

Reporter changes:

  • (#201) Do not use custom format for nil slice. Previously, the reporter had a bug (#157) where it would fail to print the difference between empty slices that were nil versus non-nil, which is now fixed by this change.
  • (#212) Use custom triple-quote syntax for diffing string literals. This adds another way that strings are displayed. Previously, the reporter used a strings.Join({...}, "\n") syntax to show diffs between lines within a string. While this representation is unambiguous, the need to escape every line made the output visually distracting. Now, we add a new syntax where multiple lines are represented by a literal syntax using """ as delimiters. When possible, this syntax is preferred if it can unambiguously represent the difference.
  • (#208) Batch reporter output for simple lists of text elements. Previously, when formatting a slice of primitives, the reporter would print each element on a new line, causing the output to be long. Now, multiple elements are batched together into a single line to keep the output more dense.
  • (#210) Allow batched diffing of slices with a custom comparer. As a performance optimization, a user may choose to pass cmp.Comparer(bytes.Equal) so that large byte slices are compared using an efficient implementation. Previously, this would prevent the reporter from being able to use specialized logic to show the per-element difference between these two slices if they were different, but now it is able to.
  • (#213, #215) Limit verbosity of reporter output. For slices, maps, and structs, the reporter now imposes a limit on the number of elements, entries, and structs that it will print. The limit is chosen based on heuristics such as the depth of the tree and also whether the node represents an equal value or not, where inequal values are given a larger verbosity budget.
  • (#216) Disambiguate reporter output. Previously, there were certain edge cases where the reporter output failed to show a difference between two values that the comparer determined to be different. Now, the reporter works harder to ensure that the output is guaranteed to be different if a semantic difference is there. For example, it may try increasing the verbosity limit, printing pointer addresses, avoid calling the String method, using fully qualified type names, or some combination of the above.

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Mar 6, 2021
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/google/go-cmp-0.5.5 branch from 596c7c7 to 42be9ff Compare March 10, 2021 18:44
@jawnsy
Copy link
Contributor

jawnsy commented Mar 10, 2021

@dependabot rebase

Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.4.0 to 0.5.5.
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](google/go-cmp@v0.4.0...v0.5.5)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/google/go-cmp-0.5.5 branch from 42be9ff to bd1493b Compare March 10, 2021 23:51
Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem reasonable and tests are passing

ty to @cmoog for the help with CI ❤️

@jawnsy jawnsy merged commit 497d474 into master Mar 11, 2021
@jawnsy jawnsy deleted the dependabot/go_modules/github.com/google/go-cmp-0.5.5 branch March 11, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants