Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker-compose file as example #680

Merged
merged 4 commits into from
Oct 29, 2019
Merged

Add docker-compose file as example #680

merged 4 commits into from
Oct 29, 2019

Conversation

marc-x-andre
Copy link
Contributor

@marc-x-andre marc-x-andre commented May 13, 2019

Describe in detail the problem you had and how this PR fixes it

There wasn't an example of how to use docker-compose with code-server.

Is there an open issue you can link to?

Yes. docker-compose examples #648

Fixes #648.

@ntindle
Copy link

ntindle commented May 13, 2019

With docker-compose, would it be trivial to add https with certbot for example purposes ?

@marc-x-andre
Copy link
Contributor Author

marc-x-andre commented May 14, 2019

With docker-compose, would it be trivial to add https with certbot for example purposes?

It could be easy, but I don't think it is in the scope of the example. The goal was to reproduce the docker command in the README:

docker run -it -p 127.0.0.1:8443:8443 -v "${PWD}:/home/coder/project" codercom/code-server --allow-http --no-auth

Copy link

@frank-dspeed frank-dspeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also mount the extension directorys so they get persisted

- "${PWD}:/home/coder/project"
environment:
PASSWORD: ${PASSWORD}
command: --allow-http --no-auth

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have PASSWORD env var, but it will not work, because the --no-auth flag is set.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add a comment here indicating that you need to remove --no-auth with a docker-compose override file or edit this one if you want to use $PASSWORD.

@sr229
Copy link
Contributor

sr229 commented Sep 12, 2019

Obsoleted by GH-857. Please rebase this to the newer tree.

@sr229 sr229 added the blocked This issue cannot proceed due to external factors label Sep 12, 2019
@nhooyr
Copy link
Contributor

nhooyr commented Sep 20, 2019

@sr229 why is this obsolete? There is no merge conflict.

@deansheather
Copy link
Member

@nhooyr @sr229 it's not obsoleted, it just uses old flags that changed since v2

@sr229 sr229 removed the blocked This issue cannot proceed due to external factors label Sep 23, 2019
@sr229
Copy link
Contributor

sr229 commented Sep 23, 2019

I manually changed it to v2 flags. I'll work on this so it can be merged.

@sr229
Copy link
Contributor

sr229 commented Oct 28, 2019

CC @code-asher feel free to merge this in or cherrypick.

@code-asher code-asher merged commit f65c9b2 into coder:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-compose examples
9 participants