Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update node version #6789

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alexandersperling
Copy link

* Update node version to solve CVE-2024-21892
@alexandersperling alexandersperling requested a review from a team as a code owner May 8, 2024 09:35
@code-asher
Copy link
Member

Thank you for the PR! This project just wraps the version used in VS Code, since that is the one that is tested and supported by them: https://github.com/microsoft/vscode/blob/main/remote/.yarnrc

Once they have updated, we can as well.

@alexandersperling
Copy link
Author

they now updated the version to 20.9.0, but this wont fix the CVE either...

@code-asher
Copy link
Member

Oh weird I wonder why they chose to do that. Oh it probably matches whatever Node version is being used in Electron...

@alexandersperling
Copy link
Author

alexandersperling commented May 16, 2024

I wonder if it should work with node 20.12.1 since this is the version which is defined in the .nvmrc

https://github.com/microsoft/vscode/blob/main/.nvmrc

You know why there are differences with the .yarnrc you linked before and the general node version used in the repo?

@code-asher
Copy link
Member

You know why there are differences with the .yarnrc you linked before and the general node version used in the repo?

I am not sure, that does seem weird. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants