Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev-deps): update ts-node and spawn #2999

Merged
merged 2 commits into from Mar 31, 2021
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Mar 29, 2021

This PR fixes how we spawn a child_process and bumps ts-node.

(H/T to @cspotcode for identifying this after we opened an issue in ts-node)

Related:

image

@jsjoeio jsjoeio added this to the v3.9.3 milestone Mar 29, 2021
@jsjoeio jsjoeio requested a review from a team as a code owner March 29, 2021 21:13
@jsjoeio jsjoeio self-assigned this Mar 29, 2021
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this!

src/node/wrapper.ts Outdated Show resolved Hide resolved
@jsjoeio jsjoeio requested a review from code-asher March 30, 2021 16:54
@jsjoeio jsjoeio marked this pull request as draft March 30, 2021 18:01
@jsjoeio jsjoeio marked this pull request as ready for review March 30, 2021 23:46
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Mar 30, 2021

bump @code-asher - ready for a second review

@jsjoeio jsjoeio enabled auto-merge March 30, 2021 23:47
@code-asher code-asher merged commit a4c8549 into main Mar 31, 2021
@code-asher code-asher deleted the jsjoeio/fix-ts-node branch March 31, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants