Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CICD] Notarize immudb4j #34

Merged
merged 2 commits into from Oct 13, 2022
Merged

[CICD] Notarize immudb4j #34

merged 2 commits into from Oct 13, 2022

Conversation

marcosanchotene
Copy link
Contributor

@marcosanchotene marcosanchotene commented Oct 7, 2022 •
edited

  • Pin reusable workflow call to commit sha for greater security and compatibility
  • Remove runs-on directive as it cannot be on calling workflow
  • Change trigger to run whenever there is a push to master and develop
  • Remove merged condition as it now runs on push

@marcosanchotene marcosanchotene changed the title [CICD] Add runs-on directive [CICD] Notarize immudb4j Oct 11, 2022
SimoneLazzaris
SimoneLazzaris approved these changes Oct 13, 2022
View reviewed changes
Copy link

@SimoneLazzaris SimoneLazzaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to use a tag for pinning action version, but it's ok

@marcosanchotene marcosanchotene merged commit 912032b into master Oct 13, 2022
@marcosanchotene marcosanchotene deleted the cicd/attestation branch October 13, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimoneLazzaris SimoneLazzaris SimoneLazzaris approved these changes

@jeroiraz jeroiraz Awaiting requested review from jeroiraz

@tomekkolo tomekkolo Awaiting requested review from tomekkolo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcosanchotene @SimoneLazzaris