New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace deprecated COMPOSER_TOKEN
with GITHUB_TOKEN
#60
Conversation
@kenjis I tried to fix error psalm error, but I'm not sure, please review. Warning: "findUnusedBaselineEntry" will be defaulted to "true" in Psalm 6. You should explicitly enable or disable this setting.
Warning: "findUnusedCode" will be defaulted to "true" in Psalm 6. You should explicitly enable or disable this setting.
Target PHP version: 7.4 (inferred from composer.json) Enabled extensions: .
Scanning files...
Deprecation: Psalm stubs for ext-apcu loaded using legacy way. Instead, please declare ext-apcu as dependency in composer.json or use <enableExtensions> and/or <disableExtensions> directives in Psalm config.
Deprecation: Psalm stubs for ext-redis loaded using legacy way. Instead, please declare ext-redis as dependency in composer.json or use <enableExtensions> and/or <disableExtensions> directives in Psalm config.
Analyzing files...
░░░░░░E░░░░░░░
ERROR: ReservedWord - src/Handlers/DatabaseHandler.php:173:31 - 'resource' is a reserved word (see https://psalm.dev/095)
if (is_bool($result = $query->get())) {
------------------------------
1 errors found
------------------------------
87 other issues found.
You can display them with --show-info=true
------------------------------
Psalm can automatically fix 30 of these issues.
Run Psalm again with
--alter --issues=MissingReturnType --dry-run
to see what it can fix.
------------------------------
Checks took 3.43 seconds and used 457.239MB of memory
Psalm was able to infer types for 90.97[13](https://github.com/codeigniter4/settings/actions/runs/3984651256/jobs/6831102637#step:9:14)% of the codebase
Error: Process completed with exit code 2. |
@datamweb It is reported in https://github.com/codeigniter4/settings/actions/runs/4075126980/jobs/7021112053 |
It seems it is vimeo/psalm#2625 It seems we need to define |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It seems Psalm does not allow to use `resource` in @template type. See - codeigniter4/settings#60 (comment) - codeigniter4/shield#195 (comment)
It seems Psalm does not allow to use `resource` in @template type. See - codeigniter4/settings#60 (comment) - codeigniter4/shield#195 (comment)
It seems Psalm does not allow to use `resource` in @template type. See - codeigniter4/settings#60 (comment) - codeigniter4/shield#195 (comment)
see codeigniter4/shield#602