Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve user guide deploy script #8900

Merged
merged 1 commit into from
May 23, 2024
Merged

chore: improve user guide deploy script #8900

merged 1 commit into from
May 23, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented May 17, 2024 •
edited

Description

  • add file extension
  • add uid check. To avoid accidentally running as root

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the github_actions Pull requests that update Github_actions code label May 17, 2024
@kenjis kenjis merged commit 47cb203 into codeigniter4:develop May 23, 2024
2 checks passed
@kenjis kenjis deleted the update-deploy-script branch May 23, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kenjis @michalsn