Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: run php-cs-fixer v3.13.1 #6990

Closed
wants to merge 1 commit into from
Closed

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 18, 2022

Description

  • run php-cs-fixer

See PHP-CS-Fixer/PHP-CS-Fixer#6590

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@michalsn
Copy link
Member

I'm not a big fan

  • it makes the code less readable in many cases
  • it's not very natural for me to write code this way (it will probably be popping up frequently)

However, I'm not sure what others think. If the majority is on board, then let it be.

Also not sure there is an easy alternative to avoid this.

@kenjis
Copy link
Member Author

kenjis commented Dec 18, 2022

To be honest, I'm also not a fan of this.

But the change is a bug fix of php-cs-fixer.
I don't know we can avoid this easily.

@kenjis
Copy link
Member Author

kenjis commented Dec 20, 2022

I created an issue: PHP-CS-Fixer/PHP-CS-Fixer#6716

@MGatner
Copy link
Member

MGatner commented Dec 20, 2022

I think we hold off on this until we see what comes of kenjis' request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants