-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPUnitTest: Extend the default PHPUnit result printer with a modern, pretty printer #5950
Conversation
This output might be easier to see and understand a bit.
|
PHPUnit 10 won't be supporting custom printer classes.
https://github.com/sebastianbergmann/phpunit/blob/main/ChangeLog-10.0.md |
The new Event System will be introduced. But no worry, if it will be not compatible with PHPUnit 10, we can simply remove it at that time. |
In these ChangeLog is PHP 7.3, PHP 7.4, and PHP 8.0 are no longer supported, is this true for codeigniter4 in the future? |
CI4 supports the Currently Supported PHP Versions. |
@kenjis Thanks , a new day, a new tip. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@datamweb makes a good case for this, especially in an era where we are trying to be more "contributor friendly". I don't like the additional dependency which (as the discussion points out) makes the future of this integration uncertain.
Alternative ideas: could we add notes to the docs on how to get this set up locally? Or include it in the CodeIgniter DevKit?
Just to call it out, here are the additional dev dependencies this would add: "hassankhan/config": "^0.11.2|^1.0|^2.0|^3.0",
"symfony/yaml": "^2.7|^3.0|^4.0|^5.0",
"codedungeon/php-cli-colors": "^1.10.2",
"2bj/phanybar": "^1.0" Also it looks like the library has some PHP 8.1 compatibility work (4 months ago) but the last release was 2 years ago; if we want to pursue this we should probably ask the maintainers to push through another release. |
Good point. Unfortunately, it doesn't seem to be maintained very properly. |
@MGatner Thank you for your importance to PR. I also disagree with the ambiguous uncertain. |
@datamweb I agree with you. Why don't you send a PR? |
Hello friends.
PR is about beautifying the output of the unit test in the terminal.
I am currently learning unit test. What I saw at the beginning of running command
vendor/bin/phpunit
caused phrases like...FF.FE.....F..
To see in the terminal.I'm a beginner, I did not know what pass, fail, error, skipped, incomplete, risky means. I now know.
In my opinion, if this package was used. In executing Command
vendor/bin/phpunit
, I was not scared at first glance.Please consider executing command
vendor/bin/phpunit
by a novice user unfamiliar with command PHPUnit as well as a user whose native language is not english. Check the subject.Using this package made me less afraid of phpunit.
Description
In addition, the package does not require much user-specific configuration, which can be confusing, although it can be customized if desired.
Checklist: