Regression: encoding error when parsing a ISO-8859-1 pom with Maven Resolver

[tmortagne]

Maven Resolver (at least the 3.6.0 one) model processor uses ReaderFactory#newXmlReader to create a XmlStreamReader and then pass it to MXParser.

Problem is that since 1e18ddc MXParser assumes the input encoding is UTF8 and only changes that if the input reader is a InputStreamReader (which is not the case here since it's a XmlStreamReader). So we end up with exception:

UTF-8 BOM plus xml decl of ISO-8859-1 is incompatible

This whole check is not really needed here since XmlStreamReader is taking care of potential encoding issues already from what I understand.

[michael-o]

Will take a look. Is your POM public?

[tmortagne]

Yes, in my case the problem was with https://repo1.maven.org/maven2/org/apache/commons/commons-parent/39/commons-parent-39.pom (when resolving the parents of commons-collections:commons-collections:3.2.2 to build its Model).

[michael-o]

@belingueres Can you have a look at this?

[tmortagne]

I feel like MXParser#fileEncoding should be null by default instead of the arbitrary "UTF8" and the check should be done only if it's not null.

[michael-o]

I feel like MXParser#fileEncoding should be null by default instead of the arbitrary "UTF8" and the check should be done only if it's not null.

So it should autodiscover the encoding itself?

[tmortagne]

So it should autodiscover the encoding itself?

No, just not compare the encoding with the declaration when it does not know what encoding the reader uses, same as before this change.

[michael-o]

So it should autodiscover the encoding itself?

No, just not compare the encoding with the declaration when it does not know what encoding the reader uses, same as before this change.

Makes sense.

[belingueres]

I'll take a look at it.

[haster]

We just ran into the same issue and after a bit of searching found the bug ... only to then see this issue that perfectly captures what's going on 😄

Thanks for raising it @tmortagne and for the quick fix @belingueres , can we expect a patch soon?

[olamy]

closes by belingueres@f999bdb

[olamy]

releasing today