Use ReaderFactory.newXmlReader() instead of ISR in MavenHelper #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plexus-utils's MXParser obtains encoding from XmlReader (see codehaus-plexus/plexus-utils#163) or from ISR.
In our case MavenHelper creates ISR, and it then reports "default" encoding, which most probably will be UTF-8.
When the pom file contains encoding declaration with something else, like ISO-8859-1 in https://repo1.maven.org/maven2/org/apache/commons/commons-parent/48/commons-parent-48.pom, this results in the error:
This PR switches to using plexus-utils's ReaderFactory, which "knows better". This eliminates the above error.