Check for negative millisecond offset #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File.setLastModified() does not allow negative values, but those can be present in Date. One such source is ZipEntry.getTime(), which returns -1 to indicate a non-applicable time. Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
plamentotev
reviewed
May 1, 2021
| final long millis = entryDate.getTime(); | ||
| if ( millis >= 0 ) | ||
| { | ||
| targetFileName.setLastModified( millis ); |
There was a problem hiding this comment.
I find setLastModified behavior strange because lastModified works perfectly fine with negative values (dates before 1970-01-01). We can use Files.setLastModifiedTime, which works with negative values[1], and use null for missing date. Some archives, such as tar, support negative values so it should be up to the specific UnArchiver implementation to decide if the date is known or not.
[1] Whether the underlying file system supports it is different question. Unfortunately the behavior is unspecified if the date is out of range for the file system. Maybe we can just catch the exception so failure to set the date does not fail the file extraction?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File.setLastModified() does not allow negative values, but those
can be present in Date. One such source is ZipEntry.getTime(), which
returns -1 to indicate a non-applicable time. Fixes #170.
Signed-off-by: Robert Varga robert.varga@pantheon.tech