Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ModelloCli broken after moving from Plexus to JSR330 #435

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

fridrich
Copy link

This is my attempt at least to make the ModelloCli.java at least start and run. It still throws an exception on simple models. But at least the guice bindings look correct and the thing is at least starting and running.

@fridrich
Copy link
Author

#434

@fridrich fridrich force-pushed the master branch 2 times, most recently from bb79a61 to f708579 Compare April 13, 2024 12:41
@fridrich
Copy link
Author

This version is now working for me and from my side, it is ready to get integrated. I don't know which kind of test to write for a command-line tool so that it does not regress any more. Please, advise.
Btw, the guice path I tried before is largely convoluted, and complicated. After I studied the commit 3c05d7a, I understood the problem.

@fridrich
Copy link
Author

fridrich commented Apr 13, 2024

The latest version actually restores the possibility to instantiate directly the Modello class, since I see now that some Fedora tools in javapackages-bootstrap do it. So this version partially reverts commit 8804652 concerning the two files and adds the configuration including the autowiring and index scanning. Like that, stuff out there that was using Modello() constructor directly, will be able to use it from this commit on again.

@fridrich fridrich changed the title Fix the ModelloCli to use Guice, since it is not Plexus component anymore Fix ModelloCli broken after moving from Plexus to JSR330 Apr 13, 2024
@fridrich
Copy link
Author

It would be good to have some test for this. Minimum that it can generate simple java files from a model. But for that, one needs basically the whole classpath including the plugins.

@fridrich
Copy link
Author

fridrich commented May 3, 2024

This is running in openSUSE since and generates on command-line the correct Java files. Any chance to have it reviewed?

@slawekjaranowski slawekjaranowski linked an issue May 4, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModelloCli is not working in 2.3.0
2 participants