Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace handwritten components.xml with annotations #285

Merged
merged 2 commits into from
Dec 30, 2022
Merged

Conversation

hboutemy
Copy link
Member

fixes #275

required a few compromises:

  • still using Plexus annotations instead of Sisu
  • one handwritten partial components.xml: because plugins parameter from parent class has different roles

but it's already a great improvement to see declaration as annotations

@kwin
Copy link
Contributor

kwin commented Dec 29, 2022

Are there technical reasons why a migration towards Sisu components is not possible or is it just to reduce implementation effort for the first step?

@hboutemy
Copy link
Member Author

hboutemy commented Dec 30, 2022

I tried to go directly with JSR-330 and Sisu, but unit tests failed: there is probably some upgrades to do that i don't precisely know
then I did the first step only, yes, as an implementation reduction effort

@hboutemy hboutemy changed the title replace most handwritten components.xml with annotations replace handwritten components.xml with annotations Dec 30, 2022
@hboutemy hboutemy merged commit 33c8523 into master Dec 30, 2022
@hboutemy hboutemy deleted the annotations branch December 30, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch from handwritten Plexus components.xml to JSR 330 annotations + Sisu
2 participants