Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Xpp3Reader#read(XmlPullParser, boolean strict) public #196

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

gnodet
Copy link
Member

@gnodet gnodet commented Mar 15, 2022

Copy link
Member

@hboutemy hboutemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh, how did we let this in that state for so many years?
thanks for the new eyes :)

@hboutemy hboutemy changed the title Make the Xpp3Reader#read(XmlPullParser, boolean) public Make the Xpp3Reader#read(XmlPullParser, boolean strict) public Mar 15, 2022
@gnodet
Copy link
Member Author

gnodet commented Mar 15, 2022

uh, how did we let this in that state for so many years?
thanks for the new eyes :)

No, that's not very old. It's coming from the build/consumer feature, and more specifically, my refactoring to use pull parsing instead of sax.

@gnodet
Copy link
Member Author

gnodet commented Mar 15, 2022

Thx for the approvals. However I have no karma on the codehaus-plexus organisation or this repo...

@michael-o michael-o merged commit b405413 into codehaus-plexus:master Mar 15, 2022
@olamy olamy added the bug label Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants