Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update httpx and httpcore #154

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Update httpx and httpcore #154

merged 2 commits into from
Oct 23, 2023

Conversation

scott-codecov
Copy link
Contributor

@scott-codecov scott-codecov commented Oct 20, 2023

I think we were running into this bug encode/httpcore#564 (as seen here: https://codecov.sentry.io/issues/4463071748)

The fix was implemented in httpcore 0.16.0: encode/httpcore#580. I updated httpx and httpcore to incorporate that fix.

Sounds like the alternative is to use asyncio.TaskGroups (which are available in Python 3.11) instead of asyncio.gather (which cancel the other tasks in the group when an exception arises in one of them)

Copy link
Contributor

@drazisil-codecov drazisil-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests pass, looks good to me.

@codecov-staging
Copy link

codecov-staging bot commented Oct 20, 2023

Codecov Report

Merging #154 (a1d14ac) into main (7e263ca) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head a1d14ac differs from pull request most recent head fd70e13. Consider uploading reports for the commit fd70e13 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
- Coverage   98.43%   98.43%   -0.01%     
==========================================
  Files         347      346       -1     
  Lines       27281    27069     -212     
==========================================
- Hits        26855    26645     -210     
+ Misses        426      424       -2     
Flag Coverage Δ
integration 98.43% <ø> (-0.01%) ⬇️
latest-uploader-overall 98.43% <ø> (-0.01%) ⬇️
unit 98.43% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.97% <ø> (-0.02%) ⬇️
OutsideTasks 98.23% <ø> (-0.01%) ⬇️

see 10 files with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Oct 20, 2023

Codecov Report

Merging #154 (fd70e13) into main (7e263ca) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files         347      347           
  Lines       27281    27281           
=======================================
  Hits        26855    26855           
  Misses        426      426           
Flag Coverage Δ
integration 98.43% <ø> (ø)
latest-uploader-overall 98.43% <ø> (ø)
unit 98.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.99% <ø> (ø)
OutsideTasks 98.23% <ø> (ø)

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 20, 2023

Codecov Report

Merging #154 (fd70e13) into main (7e263ca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files         347      347           
  Lines       27281    27281           
=======================================
  Hits        26855    26855           
  Misses        426      426           
Flag Coverage Δ
integration 98.43% <ø> (ø)
latest-uploader-overall 98.43% <ø> (ø)
unit 98.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.99% <ø> (ø)
OutsideTasks 98.23% <ø> (ø)

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #154 (fd70e13) into main (7e263ca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files         373      373           
  Lines       27860    27860           
=======================================
  Hits        27417    27417           
  Misses        443      443           
Flag Coverage Δ
integration 98.43% <ø> (ø)
latest-uploader-overall ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.92% <ø> (ø)
OutsideTasks 98.19% <ø> (ø)

This change has been scanned for critical changes. Learn more

@scott-codecov scott-codecov merged commit c73682a into main Oct 23, 2023
21 of 22 checks passed
@scott-codecov scott-codecov deleted the scott/upgrade-httpx branch October 23, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants