Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update useRepoFlagSelect to new repository type #2848

Merged
merged 17 commits into from
May 15, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented May 6, 2024

Addresses the useRepoFlagSelect line item in
codecov/engineering-team#355

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (521e89b) to head (d65ae96).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2848   +/-   ##
=======================================
  Coverage   98.47%   98.48%           
=======================================
  Files         880      880           
  Lines       13007    13037   +30     
  Branches     3463     3473   +10     
=======================================
+ Hits        12809    12839   +30     
  Misses        194      194           
  Partials        4        4           
Files Coverage Δ
src/services/pull/usePull.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoFlagsSelect.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.28% <ø> (ø)
Services 99.48% <100.00%> (+<0.01%) ⬆️
Shared 99.68% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 521e89b...d65ae96. Read the comment docs.

Copy link

codecov-public-qa bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (521e89b) to head (d65ae96).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2848   +/-   ##
=======================================
  Coverage   98.47%   98.48%           
=======================================
  Files         880      880           
  Lines       13007    13037   +30     
  Branches     3420     3429    +9     
=======================================
+ Hits        12809    12839   +30     
  Misses        194      194           
  Partials        4        4           
Files Coverage Δ
src/services/pull/usePull.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoFlagsSelect.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.28% <ø> (ø)
Services 99.48% <100.00%> (+<0.01%) ⬆️
Shared 99.68% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 521e89b...d65ae96. Read the comment docs.

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (521e89b) to head (d65ae96).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2848   +/-   ##
=====================================
  Coverage   98.48   98.48           
=====================================
  Files        880     880           
  Lines      13007   13037   +30     
  Branches    3486    3429   -57     
=====================================
+ Hits       12809   12839   +30     
  Misses       194     194           
  Partials       4       4           
Files Coverage Δ
src/services/pull/usePull.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoFlagsSelect.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.28% <ø> (ø)
Services 99.48% <100.00%> (+<0.01%) ⬆️
Shared 99.68% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 521e89b...d65ae96. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented May 6, 2024

Bundle Report

Changes will increase total bundle size by 12.1kB ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.6MB 12.1kB ⬆️

Copy link

codecov bot commented May 6, 2024

Bundle Report

Changes will increase total bundle size by 12.1kB ⬆️

Bundle name Size Change
gazebo-production-array-push 6.6MB 12.1kB ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented May 6, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
78162b6 Mon, 06 May 2024 21:08:04 GMT Expired Expired
78162b6 Mon, 06 May 2024 21:12:16 GMT Expired Expired
a2dabb9 Mon, 06 May 2024 21:28:51 GMT Expired Expired
27d7d02 Mon, 06 May 2024 21:40:51 GMT Expired Expired
b654719 Tue, 07 May 2024 17:24:27 GMT Expired Expired
9c94a2f Wed, 08 May 2024 14:02:18 GMT Expired Expired
6195712 Wed, 08 May 2024 14:35:53 GMT Expired Expired
6195712 Wed, 08 May 2024 14:36:53 GMT Expired Expired
6d74aed Wed, 08 May 2024 14:59:49 GMT Expired Expired
1b7b18f Wed, 08 May 2024 15:21:18 GMT Expired Expired
ef2899e Tue, 14 May 2024 21:17:28 GMT Expired Expired
d65ae96 Wed, 15 May 2024 14:20:56 GMT Cloud Enterprise

@codecov-staging
Copy link

codecov-staging bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2848   +/-   ##
=======================================
  Coverage   98.47%   98.48%           
=======================================
  Files         880      880           
  Lines       13007    13037   +30     
  Branches     3486     3429   -57     
=======================================
+ Hits        12809    12839   +30     
  Misses        194      194           
  Partials        4        4           
Files Coverage Δ
src/services/pull/usePull.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoFlagsSelect.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.28% <ø> (ø)
Services 99.48% <100.00%> (+<0.01%) ⬆️
Shared 99.68% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 521e89b...d65ae96. Read the comment docs.

@rohitvinnakota-codecov rohitvinnakota-codecov changed the title [draft] Update useRepoFlagSelect to new repository type Update useRepoFlagSelect to new repository type May 8, 2024
@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review May 8, 2024 15:09
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm one nit, but your call if it's worth the CI run 😆

@rohitvinnakota-codecov rohitvinnakota-codecov added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 035366c May 15, 2024
57 of 58 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/update-flag-select-to-repo branch May 15, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants