Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

More retries #273

Merged
merged 9 commits into from Jun 12, 2020
Merged

More retries #273

merged 9 commits into from Jun 12, 2020

Conversation

thomasrockhu
Copy link
Contributor

@thomasrockhu thomasrockhu commented Jun 11, 2020

Inspired by https://github.com/nmoinvaz/codecov-python/commit/19f958fce8f34c06fa7dd7a1ebfbad216653041b with a little less infrastructure

Retry our API calls for a little more resiliency

@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #273   +/-   ##
=====================================
  Coverage      88%    88%           
=====================================
  Files           2      2           
  Lines           9      9           
=====================================
  Hits            8      8           
  Misses          1      1           

@thomasrockhu thomasrockhu marked this pull request as ready for review June 11, 2020 22:47
@thomasrockhu
Copy link
Contributor Author

cc: @nmoinvaz

@thomasrockhu thomasrockhu merged commit 07583f3 into master Jun 12, 2020
@thomasrockhu thomasrockhu deleted the more-retries branch June 12, 2020 14:34
@nmoinvaz
Copy link
Contributor

nmoinvaz commented Jun 12, 2020

Only part I am unsure of is the try/catch line: except AssertionError:

It seems that perhaps that will only catch assert lines. But what if requests library call throws its own exception, ie: except (requests.exceptions.RequestException, requests.urllib3.exceptions.HTTPError):

If there was a connection error..

@nmoinvaz
Copy link
Contributor

Also would you be open to a PR that allows the number of retries to be configurable via command line arg?

@thomasrockhu
Copy link
Contributor Author

@nmoinvaz I'll add a PR for the first issue, feel free to open one for the second

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants