Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Include the cacert in the PUT call when uploading to S3 #187

Closed
wants to merge 4 commits into from

Conversation

jsiirola
Copy link
Contributor

This PR adds a verify=codecov.cacert argument to the put() call when uploading results to S3. This resolves a problem where a user-specified CACert file is required to successfully connect to the codecov server. The initial connection to codecov ('Pinging codecov...') includes the CACert and is successful, but the subsequent upload fails because the CACert was not included.

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #187 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #187   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           1      1           
  Lines           1      1           
=====================================
  Misses          1      1           

@thomasrockhu thomasrockhu self-requested a review May 27, 2020 16:30
@nmoinvaz
Copy link
Contributor

@thomasrockhu I can create a new PR for this issue with conflicts resolved if you would like.

@thomasrockhu
Copy link
Contributor

@nmoinvaz yes please, or resolve conflicts, your choice

@nmoinvaz
Copy link
Contributor

I don't have the ability to edit the PR so I created #266 based on updated commit.

@thomasrockhu
Copy link
Contributor

Closed via #266

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants