Switch from execSync to execFileSync

codecov · May 19, 2020 · b7c9e4e · b7c9e4e
1 parent bb79335
commit b7c9e4e
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/.idea/.gitignore b/.idea/.gitignore
diff --git a/lib/codecov.js b/lib/codecov.js
@@ -4,6 +4,7 @@ var request = require('teeny-request').teenyRequest
 var urlgrey = require('urlgrey')
 var jsYaml = require('js-yaml')
 var walk = require('ignore-walk')
+var execFileSync = require('child_process').execFileSync
 var execSync = require('child_process').execSync
 
 var detectProvider = require('./detect')
@@ -355,7 +356,7 @@ var upload = function(args, on_success, on_failure) {
   console.log('==> Building file structure')
   try {
     upload +=
-      execSync('git ls-files || hg locate', { cwd: root })
+      execFileSync('git', ['ls-files', '||', 'hg', 'locate'], { cwd: root })
         .toString()
         .trim() + '\n<<<<<< network\n'
   } catch (err) {
@@ -414,7 +415,7 @@ var upload = function(args, on_success, on_failure) {
       }
       debug.push(gcov)
       console.log('    $ ' + gcov)
-      execSync(gcov)
+      execFileSync(gcov)
     } catch (e) {
       console.log('    Failed to run gcov command.')
     }
@@ -431,7 +432,9 @@ var upload = function(args, on_success, on_failure) {
       .toString()
       .trim()
   } else {
-    bowerrc = execSync('if exist .bowerrc type .bowerrc', { cwd: root })
+    bowerrc = execFileSync('if', ['exist', '.bowerrc', 'type', '.bowerrc'], {
+      cwd: root,
+    })
       .toString()
       .trim()
   }
@@ -475,14 +478,16 @@ var upload = function(args, on_success, on_failure) {
     console.log('==> Scanning for reports')
     var _files
     if (!isWindows) {
-      _files = execSync('find ' + root + ' ' + patterns + more_patterns)
+      // @TODO support for a root directory
+      // It's not straightforward due to the nature of the find command
+      _files = execFileSync('find', [root, patterns, more_patterns])
         .toString()
         .trim()
         .split('\n')
     } else {
       // @TODO support for a root directory
       // It's not straightforward due to the nature of the dir command
-      _files = execSync('dir ' + patterns + more_patterns)
+      _files = execFileSync('dir', [patterns, more_patterns])
         .toString()
         .trim()
         .split('\r\n')