Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Commit

Permalink
Merge pull request #200 from codecov/remove-flaky-test
Browse files Browse the repository at this point in the history
Remove flaky test and update README
  • Loading branch information
thomasrockhu committed Aug 12, 2020
2 parents 9d73613 + 4daaf53 commit 2edb1b1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 32 deletions.
9 changes: 5 additions & 4 deletions README.md
@@ -1,9 +1,9 @@
# Codecov NodeJS Uploader

[![codecov.io](https://codecov.io/github/codecov/codecov-node/coverage.svg?branch=master)](https://codecov.io/github/codecov/codecov-node?branch=master)
[![NPM version][npm-image]][npm-url]
[![Build Status][github-actions-image]][github-actions-url]
[![Build Status][travis-image]][travis-url]
[![Build Status][appveyor-image]][appveyor-url]
[![codecov.io](https://codecov.io/github/codecov/codecov-node/coverage.svg?branch=master)](https://codecov.io/github/codecov/codecov-node?branch=master)
[![Dependency Status][depstat-image]][depstat-url]
[![Dev Dependency Status][devdepstat-image]][devdepstat-url]

Expand Down Expand Up @@ -68,10 +68,11 @@ istanbul cover test.js
./node_modules/.bin/codecov
```

[appveyor-url]: https://ci.appveyor.com/project/eddiemoore/codecov-node-s38o6/branch/master
[github-actions-image]: https://github.com/codecov/codecov-node/workflows/Node%20CI/badge.svg
[github-actions-url]: https://github.com/codecov/codecov-node/actions?query=workflow%3A%22Node+CI%22
[travis-image]: https://travis-ci.org/codecov/codecov-node.svg?branch=master
[travis-url]: https://travis-ci.org/codecov/codecov-node
[appveyor-image]: https://ci.appveyor.com/api/projects/status/ea1suiv0tprnq61l?svg=true
[appveyor-url]: https://ci.appveyor.com/project/eddiemoore/codecov-node/branch/master
[npm-url]: https://npmjs.org/package/codecov
[npm-image]: https://img.shields.io/npm/v/codecov.svg
[depstat-url]: https://david-dm.org/codecov/codecov-node
Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
Expand Up @@ -12,7 +12,7 @@ init:
- git config --global core.autocrlf true

install:
- ps: Install-Product node $env:nodejs_version
- ps: Install-Product node $env:nodejs_version x64
- npm install

test_script:
Expand Down
27 changes: 0 additions & 27 deletions test/upload.test.js
Expand Up @@ -67,31 +67,4 @@ describe('Codecov', function() {
}
)
})

it("upload v2 doesn't throw runtime error", function(done) {
expect(
codecov.sendToCodecovV2.bind(
null,
'https://codecov.io',
{
token: 'f881216b-b5c0-4eb1-8f21-b51887d1d506',
commit: 'c739768fcac68144a3a6d82305b9c4106934d31a',
branch: 'master',
},
'testing node-' + codecov.version,
function(body) {
expect(body).toContain(
'https://codecov.io/github/codecov/ci-repo/commit/c739768fcac68144a3a6d82305b9c4106934d31a'
)
done()
},
function(errCode, errMsg) {
if (offlineErrors.indexOf(errCode) !== -1) {
done()
}
throw new Error(errMsg)
}
)
).not.toThrow()
})
})

0 comments on commit 2edb1b1

Please sign in to comment.