This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Remove unused header #107
Closed
Remove unused header #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasrockhu
force-pushed
the
remove-x-amz-acl-headers
branch
from
b33f80d
to
62537e4
Compare
|
Oops, didn't see #105 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some changes in the Codecov infrastructure, we no longer accept this header. You can see the change made in the bash, python, and node uploaders.
I'll be honest @AdmiringWorm, I'm not too knowledgeable on this uploader or with C#. I'm somewhat confident that I did the change correctly, but I'd really love your eyes on it to double-check.
Currently users are seeing a 400 from Codecov on uploads as it then defaults to the
CodecovFallbackUploader.