Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Remove Public Read header from presigned PUT #105

Merged
merged 4 commits into from Jun 10, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
Expand Up @@ -101,6 +101,10 @@ All types of contributions are welcome! Feel free to open an [issue](https://git

- Specifiyng file paths with spaces is currently not possible without a workaround.
This is expected to be fixed when a new major release of codecov-exe is released (See issue [#71](https://github.com/codecov/codecov-exe/issues/71) for possible workaround and tracking).

- If you're seeing an **HTTP 400 error when uploading reports to S3**, make sure you've updated to at least version 1.11.0.



## Maintainers

Expand Down
3 changes: 2 additions & 1 deletion Source/Codecov/Upload/CodecovUploader.cs
Expand Up @@ -43,7 +43,8 @@ protected virtual void ConfigureContent(HttpContent content)
}

protected virtual void ConfigureRequest(HttpRequestMessage request)
hootener marked this conversation as resolved.
Show resolved Hide resolved
=> request.Headers.TryAddWithoutValidation("x-amz-acl", "public-read");
{
}

protected virtual HttpResponseMessage CreateResponse(HttpRequestMessage request)
{
Expand Down