Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Commit

Permalink
Merge pull request #105 from codecov/fix_public_read_header
Browse files Browse the repository at this point in the history
  • Loading branch information
AdmiringWorm committed Jun 10, 2020
2 parents 89b457b + c0c41ba commit d88ddc7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
4 changes: 4 additions & 0 deletions README.md
Expand Up @@ -101,6 +101,10 @@ All types of contributions are welcome! Feel free to open an [issue](https://git

- Specifiyng file paths with spaces is currently not possible without a workaround.
This is expected to be fixed when a new major release of codecov-exe is released (See issue [#71](https://github.com/codecov/codecov-exe/issues/71) for possible workaround and tracking).

- If you're seeing an **HTTP 400 error when uploading reports to S3**, make sure you've updated to at least version 1.11.0.



## Maintainers

Expand Down
3 changes: 2 additions & 1 deletion Source/Codecov/Upload/CodecovUploader.cs
Expand Up @@ -43,7 +43,8 @@ protected virtual void ConfigureContent(HttpContent content)
}

protected virtual void ConfigureRequest(HttpRequestMessage request)
=> request.Headers.TryAddWithoutValidation("x-amz-acl", "public-read");
{
}

protected virtual HttpResponseMessage CreateResponse(HttpRequestMessage request)
{
Expand Down

0 comments on commit d88ddc7

Please sign in to comment.