fix: avoid emitting warnings when ruby is run with -w
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've also turned on warnings for this gem's tests, to make it more obvious when this is happening in the future. Without this fix, users will see repeated messages like this: > source_file_formatter.rb:20: warning: instance variable @line_coverage not initialized
|
Just encountered this issue as well. @fede-moya since the issue is annoying and the fix is trivial, could you please merge the PR and publish a new gem version? |
|
@noahd1 hate to bother you, but any chance you could merge this? |
|
My apologies folks, will be more proactive next time. Version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also turned on warnings for this gem's tests, to make it more obvious when this is happening in the future.
Without this fix, users will see repeated messages like this: