Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null metaspace values explicitly when rendering memory charts #1801

Merged
merged 1 commit into from Sep 10, 2021

Conversation

nathankooij
Copy link

After the upgrade to SBA 2.5.0, I noticed an error started to appear in the console when accessing the details page of an instance (notice the NaN), although rendering seems fine:

Error: <path> attribute d: Expected number, "M0,NaNL24.095068694…".

I tracked this down to the upgrade of the d3-scale library (as part of 4b72b42), where in d3/d3-scale#241 they started to treat null values as undefined which get coerced to NaN. Just like

, we should also handle null values explicitly here. This also resolves the errors in my local setup.

@codecov-commenter
Copy link

Codecov Report

Merging #1801 (7a0940f) into master (9257bf2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1801   +/-   ##
=========================================
  Coverage     83.71%   83.71%           
  Complexity     1244     1244           
=========================================
  Files           156      156           
  Lines          3628     3628           
  Branches        256      256           
=========================================
  Hits           3037     3037           
  Misses          462      462           
  Partials        129      129           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9257bf2...7a0940f. Read the comment docs.

@SteKoe SteKoe merged commit 5b1fe1b into codecentric:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants