Handle null
metaspace values explicitly when rendering memory charts
#1801
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the upgrade to SBA 2.5.0, I noticed an error started to appear in the console when accessing the details page of an instance (notice the
NaN
), although rendering seems fine:I tracked this down to the upgrade of the
d3-scale
library (as part of 4b72b42), where in d3/d3-scale#241 they started to treatnull
values asundefined
which get coerced toNaN
. Just likespring-boot-admin/spring-boot-admin-server-ui/src/main/frontend/views/instances/details/mem-chart.vue
Line 81 in 9257bf2
null
values explicitly here. This also resolves the errors in my local setup.