Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t raise an exception on SIGTERM #1820

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Don’t raise an exception on SIGTERM #1820

merged 1 commit into from
Oct 17, 2022

Commits on Oct 16, 2022

  1. Don’t raise an exception on SIGTERM 

    Looking at our Rollbar quota, the large majority of the errors we get
there come from, I believe, the recurring Heroku restart that happens.
I see no reason to report these to Rollbar, since they are expected
and, at least while using Heroku, necessary.

Luckily, looks like [Puma has an option for this][0], so it makes sense
to me to turn it on (or rather off, since we’re setting it to `false`).
[Found it][1] while doing some research on this subject, since I’ve had
a feeling I’ve seen it before.

[0]: https://www.rubydoc.info/gems/puma/Puma%2FDSL:raise_exception_on_sigterm
[1]: puma/puma#1438
    @gnclmorais
    gnclmorais committed Oct 16, 2022
    Configuration menu
    Copy the full SHA
    8372d22 View commit details
    Browse the repository at this point in the history