Link pyodide build into dashboard/public #58547
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes pyodide available on the
/pyodidestudio URL in both local dev mode and in non-local dev mode (e.g. prod).This PR:
rake package:apps:symlink(called as part of rake install) to install a symlink fromdashboard/public/pyodide(available on the studio URL /pyodide) to either apps/build/package (local dev) or dashboard/public/apps-package (non-local dev).loadPyodide()wasm and whl files from the local server at URL/pyodide/{version}Why? Pyodide build is available in two different local paths depending on whether we're in local dev mode or not:
use_my_apps: true(i.e. we're in local apps dev mode), we have webpack configured (using @pyodide/pyodide-webpack-plugin) to build pyodide into apps/build/package/js/pyodide. This is uploaded to S3 as part of staging & test builds as an apps-package tarball.use_my_apps: false, we use the apps-package from S3, which has the pyodide build available in dashboard/public/apps-package/js/pyodideCan test using: http://localhost-studio.code.org:3000//s/allthethings/lessons/50/levels/1
An alternative approach to the problem is here: #58547