Create lab2 showcase progression on allthethings and add to bubble choice UI test #58538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanchitmalhotra126
requested review from
lfryemason
and removed request for
a team
| @@ -39,3 +39,68 @@ Feature: BubbleChoice | |||
| When I click selector ".teacher-panel table td:contains(Alice)" once I see it to load a new page | |||
| And I wait for 4 seconds | |||
| Then I verify progress for the sublevel with selector ".uitest-bubble-choice:eq(0) .progress-bubble:first" is "perfect" | |||
|
|
|||
| Scenario: Lab2 BubbleChoice progress | |||
There was a problem hiding this comment.
Tagged @code-dot-org/teacher-tools just as an FYI that I updated this UI test
molly-moen
reviewed
May 14, 2024
molly-moen
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a "Lab2 showcase" progression on allthethings as a place to test various cross-lab2 functionality. The immediate need for this was to add a UI test for bubble choice sublevels on lab2, which has been added to bubble_choice.feature. Also includes a related convenience fix to handle invalid sources in Weblab2.
Demo:
(note that the light mode footer for music lab showing up in this video is a known issue, only manifesting when music lab is part of a progression with other light mode lab2 labs. This will not manifest on any production music lab levels).
Lab2Showcase.mp4
Testing story
Ran UI tests against localhost with saucelabs connect.