Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding bubble choice options to multi and external level editors #58537

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from

Conversation

kakiha11
Copy link
Contributor

This adds the ability for levelbuilders to add bubble choice descriptions and thumbnail URLs to Multi and External/Markdown level types.

This shows the fields added to a multi level editor

Screenshot 2024-05-10 at 1 50 01 PM

This shows a bubble choice level with one multi and one external/markdown level that have descriptions and thumbnail URLs added

Screenshot 2024-05-10 at 1 49 10 PM

Links

Slack Thread

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@davidsbailey
Copy link
Member

I am already seeing this option on levelbuilder for multi levels: https://levelbuilder-studio.code.org/levels/60298/edit what am I missing?
Screenshot 2024-05-10 at 4 30 50 PM

Also, when I pull down the PR, and make an edit in this field and press save, I am not seeing anything serialized to the filesystem. if this is working for you, maybe you can provide some details or a video of how you validated so I can try to follow the same steps?

@kakiha11
Copy link
Contributor Author

@davidsbailey Here are screenshots from the dashboard console on a multi level where I updated both the display name and the bubble choice description

Before

Screenshot 2024-05-14 at 1 18 37 PM

After

Screenshot 2024-05-14 at 1 19 25 PM

Is there another way I could verify this update is happening?

@davidsbailey
Copy link
Member

Is there another way I could verify this update is happening?

Yes, when you make an edit to a level on levelbuilder, it needs to be updated in the database and in the filesystem. if it is not updated in the filesystem, then the change will not make it off of levelbuilder and into other environments. For example, when I go and make an edit to a different part of a multi level:
Screenshot 2024-05-14 at 2 15 10 PM

I can see my updates to one of the old fields, but not to the new field:
Screenshot 2024-05-14 at 2 15 44 PM

if you are seeing both, then it's possible I have something misconfigured on my end. if not, then it is time to look at the dsl_text you are sending from the client to make sure it includes the new data:

Screen.Recording.2024-05-14.at.2.21.37.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants