Cleaning up School Infos validation and dedup processing

[hannahbergam]

We used to send a honeybadger error if a user was trying to submit data that didn't align with our school database data. This usually meant they were selecting a school type (i.e. private, charter, public) that mismatched their accurate school type. Unfortunately, the old search didn't filter the search results on that input, so these mismatches were entirely possible.

In the new search, the zip code will just return the schools without asking for a school type at all, so it's no longer relevant. And for the old search, we want to override the info with school data anyway (which means the Honeybadger event is no longer necessary).

Bethany and I looked at this together and started working on it a few weeks ago, with her draft work in this pr: https://github.com/code-dot-org/code-dot-org/pull/58259/files.

Links

• spec:
• jira ticket: https://codedotorg.atlassian.net/browse/ACQ-1843

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

• Tests provide adequate coverage
• Privacy and Security impacts have been assessed
• Code is well-commented
• New features are translatable or updates will not break translations
• Relevant documentation has been added or updated
• User impact is well-understood and desirable
• Pull Request is labeled appropriately
• Follow-up work items (including potential tech debt) are tracked and linked

[bethanyaconnor]

One rambling thinking-out-loud comment that ended in a nit but otherwise this looks great! Thanks for this clean up!