Update carousel to use Swiper on hourofcode.com/ai #58531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelbyhawn
commented
May 10, 2024
| @@ -1,19 +1,17 @@ | |||
| - video_item_index = 9 | |||
|
|
|||
| - video_embed_link = ["X-AWdfSFCHQ", "X994dDnmRmY", "Ok-xpKjKp2g", "OeU5m6vRyCk", "x2mRoFNm22g", "JrXazCEACVo", "2hXG8v8p0KM", "tJQSyzBUAew", "zNxw5gJtHLc"] | |||
| - video_embed_link = ["Ok-xpKjKp2g", "OeU5m6vRyCk", "x2mRoFNm22g", "JrXazCEACVo", "2hXG8v8p0KM", "X-AWdfSFCHQ", "X994dDnmRmY", "tJQSyzBUAew", "zNxw5gJtHLc"] | |||
There was a problem hiding this comment.
I updated this list order to match what we have on https://code.org/videos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the carousels on https://hourofcode.com/ai to use Swiper.
This PR also sets up the HoC site to use Swiper easily from here on out! I copied over the styles from the code.org site so they look identical and are responsive and work with LTR and RTL languages (although RTL is not set up on this page, but that is out of scope for this ticket).
Links
Jira ticket: ACQ-1883
Testing story
Tested locally
Video carousel
Videos.mov
Action block carousels
Blocks_01.mov
Blocks_02.mov
Blocks_03.mov