Rearrange eval rubric job file and extract helper classes #58510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
force-pushed
the
rerrange-eval-rubric-job-file
branch
from
7cf5ff8
to
0ba9b2f
Compare
davidsbailey
force-pushed
the
rerrange-eval-rubric-job-file
branch
from
0ba9b2f
to
3110724
Compare
davidsbailey
requested review from
Nokondi and
a team
and removed request for
a team
Nokondi
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #58411 (comment) . also extracts some code which tutor may want to share soon.
no expected changes in behavior.
Testing story
relying on existing test coverage, including