P20-903: Display U13 Warning on Section Creation to USA teachers #58497
Conversation
| @@ -41,6 +41,7 @@ def current | |||
| ai_tutor_access_denied: !!current_user.ai_tutor_access_denied, | |||
| has_seen_progress_table_v2_invitation: current_user.has_seen_progress_table_v2_invitation?, | |||
| date_progress_table_invitation_last_delayed: current_user.date_progress_table_invitation_last_delayed, | |||
| us_state: current_user.us_state, | |||
There was a problem hiding this comment.
Do we currently have us_state for teachers? I was under the impression we dont retrieve us_state for teachers but instead will use the school's state.
There was a problem hiding this comment.
You will need to look up the school_info associated with the teacher. There is state attribute on the SchoolInfo model. When @mgc1194 and I were looking at it, we saw values like CO and Colorado, so you will need to do some pattern matching.
| const showStudentsToSectionPermissionWarning = | ||
| inUSA && | ||
| currentUser.isTeacher && | ||
| experiments.isEnabledAllowingQueryString(experiments.CPA_EXPERIENCE); |
There was a problem hiding this comment.
(inUSA &&
currentUser.isTeacher) ||
experiments.isEnabledAllowingQueryString(experiments.CPA_EXPERIENCE);
Should this be an OR statement? My understanding is that the experiment is a way for us to override the conditions for the banner to appear.
There was a problem hiding this comment.
Yep. Should be an || as Mario suggests, I think.
With the && it would only show the banner if the cpa_experience DCDO flag is set (or you set it in the URL or via enableExperiments=). That flag is not set in production, so it wouldn't show at all. I think the intent is to actually roll this out.
That flag should just force you into a situation where things are acting like they would if you were a targeted user and the entire feature is live.
I think I like updating it to an || so it's live on deploy that it can still be forced on for testing via that flag.
Links