Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom error page for 500 errors #58495

Merged
merged 1 commit into from May 14, 2024

Conversation

stephenliang
Copy link
Member

@stephenliang stephenliang commented May 9, 2024

A new sad bee page was created specifically for 500s to instruct the user to sign out, clear cookies, and run other troubleshooting steps that most commonly resolve 500 errors. However, this page does not apply to other error codes (503, 504, 404, etc.) as we don't necessarily want users to be signing out when the server is timing out or having other issues.

sad bee new

Testing story

Created adhoc with adhoc:cdn:start

Updated config/adhoc.yml.erb and set custom_error_response to true. Observed updated distribution error page configuration

image

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@stephenliang stephenliang requested a review from a team May 9, 2024 21:37
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks!

@stephenliang stephenliang merged commit 8d1e2d2 into staging May 14, 2024
2 checks passed
@stephenliang stephenliang deleted the stephen/cloudfront-error-page branch May 14, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants