Music: fix preview plays #58491
Merged
Music: fix preview plays #58491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apps/src/music/player/MusicPlayer.ts
Outdated
| @@ -353,6 +353,7 @@ export default class MusicPlayer { | |||
| effects: soundEvent.effects, | |||
| originalBpm: soundData.bpm || DEFAULT_BPM, | |||
| pitchShift: this.calculatePitchShift(soundData), | |||
| preview: soundData.type === 'preview', | |||
There was a problem hiding this comment.
Can we instead check this in calculatePitchShift and just return a pitch shift of 0 if soundData.type === preview (similar to how we do for 'beat')?
Looks like we'd still need some field to also indicate that we don't want tempo adjustment but then maybe we can rename this to disableTempoAdjustment or similar?
sanchitmalhotra126
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, plays of sounds marked with a
typeof"preview"no longer have their pitch shifted or rate changed. This allows previews of packs (both in the pack dialog and the sound panel) to play in their original form, even if the current project is set to a different BPM or key.